feat(websocket): handle ping messages sent from react and add logging #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| logInfof("ping message received: %s", string(msg)) | ||
| err = wsCon.Write(context.Background(), websocket.MessageText, pongMessage) | ||
| if err != nil { | ||
| logWarnf("unable to write pong message: %v", err) |
There was a problem hiding this comment.
Error during pong message write may abruptly terminate the connection if encountered. Consider handling the error more gracefully (e.g., logging the error and possibly attempting a retry or closing the connection in a controlled manner).
Suggested change
| logWarnf("unable to write pong message: %v", err) | |
| logWarnf("unable to write pong message: %v", err) | |
| closeErr := wsCon.Close(websocket.StatusInternalError, "error writing pong message") | |
| if closeErr != nil { | |
| logWarnf("error closing websocket connection: %v", closeErr) | |
| } |
adamshiervani
approved these changes
Apr 10, 2025
ym
added a commit
that referenced
this pull request
Apr 10, 2025
ym
added a commit
to ym/jetkvm-kvm
that referenced
this pull request
Jun 13, 2025
ym
added a commit
to ym/jetkvm-kvm
that referenced
this pull request
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-use-websocket' sends aping' message instead of the control frame defined in RFC6455, as sending the opcode is currently not supported by some browsers.This PR adds support for ping messages and logging.